Do not run lintcheck summary on feature-freezed PRs #15272
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Wouldn't a better fix look for the proper lintcheck comment using the API and replace it, rather than edit the latest comment done by the bot whatever it is? Or, simpler, post a new comment with lintcheck results instead of editing the existing one? (and post a comment saying "No lintcheck changes detected" where there are no lintcheck changes)
| @@ -24,7 +24,8 @@ permissions: | |||
| jobs: | |||
| download: | |||
| runs-on: ubuntu-latest | |||
| if: ${{ github.event.workflow_run.conclusion == 'success' }} | |||
| # FIXME(feature freeze): Make sure to remove that last part after the feature freeze is over | |||
| if: ${{ github.event.workflow_run.conclusion == 'success' && ! contains(github.event.pull_request.labels.*.name, 'A-new-lint') }} | |||
There was a problem hiding this comment.
The name of the lint is A-lint.
It would be a better fix, but the gh cli doesn't put it easy when it comes to editing comments when they're not the last one.
With this approach (more suited to the temporary nature that the feature freeze has), we run the risk of spamming PRs. I'm not sure what is worse in this scenario. |
Correct label name
blyxyas
force-pushed
the
do-not-overwrite-comment
branch
from
89b023d to
f065537
Compare
Make sure that lintcheck summary comment do not overwrite PRs with the
A-new-lintlabel that is applied on freezed PRs. As the lintcheck summary action runs after conclusion and after lintcheck, it's impossible that it gets executed before applying the label.(Also, those spaces I added are not an accident, GHA treats empty lines very weirdly)
r? @flip1995
changelog: none